Do not cache isClassique flag #120
Open
+11
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: darrell-k <[email protected]>
Contributor
|
@darrell-k I'm going to depend on your regression testing for this change, as I have neither the knowledge nor the classical content in my library to do a good job of it. I think I understand the logic and it seems fairly straightforward. Go ahead and merge it whenever you are ready. |
Contributor
Author
|
Although unlikely (scanning the code shows little usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not cache the
isClassiqueflag because it may need to be reevaluated due to user preference changes (Enhanced classical music displayandAdditional classical genres).I didn't want to invalidate the entire Qobuz cache due to preference changes, so I've added a function to evaluate it every time it is needed.
@SamInPgh , please some regression testing (classical and non-classical albums, plugin browsing/play queue and import). Thanks.